<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [JHBuild] Move to upstream OpenWebRTC"
href="https://bugs.webkit.org/show_bug.cgi?id=144145#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [JHBuild] Move to upstream OpenWebRTC"
href="https://bugs.webkit.org/show_bug.cgi?id=144145">bug 144145</a>
from <span class="vcard"><a class="email" href="mailto:pnormand@igalia.com" title="Philippe Normand <pnormand@igalia.com>"> <span class="fn">Philippe Normand</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=144145#c6">comment #6</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=144145#c4">comment #4</a>)
> > Locally the checkout works, but fails to build with clang:
> >
> > CC owr_transport_agent.lo
> > owr_transport_agent.c:2339:14: error: use of undeclared identifier
> > 'GST_RTCP_RTPFB_TYPE_RTCP_SR_REQ'; did
> > you mean 'GST_RTCP_RTPFB_TYPE_RCTP_SR_REQ'?
> > case GST_RTCP_RTPFB_TYPE_RTCP_SR_REQ:
> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > GST_RTCP_RTPFB_TYPE_RCTP_SR_REQ
> > /home/martin/WebKit-old/WebKitBuild/DependenciesGTK/Root/include/gstreamer-1.
> > 0/gst/rtp/gstrtcpbuffer.h:92:3: note:
> > 'GST_RTCP_RTPFB_TYPE_RCTP_SR_REQ' declared here
> > GST_RTCP_RTPFB_TYPE_RCTP_SR_REQ = 5,
> > ^
> > 1 error generated.
>
> Zan informed me that this issue is due to a missing patch in
> gst-plugins-base. We should change the JHBuild version when adding patches
> to existing modules. I believe this will cause JHBuild to actually apply the
> patch. Not doing so can cause problems.</span >
I didn't know about this other JHBuild peculiarity. I thought the WebKitBuild/DependenciesGTK was wiped out after each jhbuild.modules update anyway?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>