<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Use xattrs to get/set the creation time of disk cache files"
href="https://bugs.webkit.org/show_bug.cgi?id=144251#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Use xattrs to get/set the creation time of disk cache files"
href="https://bugs.webkit.org/show_bug.cgi?id=144251">bug 144251</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=144251#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=251727&action=diff" name="attach_251727" title="Patch">attachment 251727</a> <a href="attachment.cgi?id=251727&action=edit" title="Patch">[details]</a></span>
> Patch</span >
Thanks for the review.
<span class="quote">> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=251727&action=review">https://bugs.webkit.org/attachment.cgi?id=251727&action=review</a>
>
> > Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystemPosix.h:86
> > +#if USE(SOUP)
>
> The correct guard here is probably #elif USE(SOUP) && OS(LINUX) unless
> g_file_query allows xattrs to work properly on Windows.</span >
This is in a file called NetworkCacheFileSystemPosix.h in WebKit2 subdir, so no windows support at all.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>