<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:fpizlo@apple.com" title="Filip Pizlo <fpizlo@apple.com>"> <span class="fn">Filip Pizlo</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Function allocation sinking works for wrong reasons"
href="https://bugs.webkit.org/show_bug.cgi?id=144176">bug 144176</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #251764 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Function allocation sinking works for wrong reasons"
href="https://bugs.webkit.org/show_bug.cgi?id=144176#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Function allocation sinking works for wrong reasons"
href="https://bugs.webkit.org/show_bug.cgi?id=144176">bug 144176</a>
from <span class="vcard"><a class="email" href="mailto:fpizlo@apple.com" title="Filip Pizlo <fpizlo@apple.com>"> <span class="fn">Filip Pizlo</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=251764&action=diff" name="attach_251764" title="Seems to be doing the right thing">attachment 251764</a> <a href="attachment.cgi?id=251764&action=edit" title="Seems to be doing the right thing">[details]</a></span>
Seems to be doing the right thing
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=251764&action=review">https://bugs.webkit.org/attachment.cgi?id=251764&action=review</a>
<span class="quote">>> Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp:812
>> + if (target->op() != NewObject)
>
> Unsure if I should add a helper function in DFG::Node for that...</span >
Seems wrong - MaterializeNewObject is also a sink candidate.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>