<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:timothy@apple.com" title="Timothy Hatcher <timothy@apple.com>"> <span class="fn">Timothy Hatcher</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: assertion failure when editing inline styles"
href="https://bugs.webkit.org/show_bug.cgi?id=143939">bug 143939</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #251139 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: assertion failure when editing inline styles"
href="https://bugs.webkit.org/show_bug.cgi?id=143939#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: assertion failure when editing inline styles"
href="https://bugs.webkit.org/show_bug.cgi?id=143939">bug 143939</a>
from <span class="vcard"><a class="email" href="mailto:timothy@apple.com" title="Timothy Hatcher <timothy@apple.com>"> <span class="fn">Timothy Hatcher</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=251139&action=diff" name="attach_251139" title="patch">attachment 251139</a> <a href="attachment.cgi?id=251139&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=251139&action=review">https://bugs.webkit.org/attachment.cgi?id=251139&action=review</a>
Looks good! Make these tweaks and I can r+ this.
<span class="quote">> Source/WebInspectorUI/UserInterface/Controllers/CSSStyleManager.js:134
> + if (styleSheet.isCssInlineStyle)</span >
See below. This will need to change to: styleSheet.isInlineStyle()
<span class="quote">> Source/WebInspectorUI/UserInterface/Models/CSSStyleSheet.js:87
> + get isCssInlineStyle()</span >
CSS should be all caps. No XMLHttpRequest precedent here. I don't think repeating CSS is needed either.
We also don't use is for getters. This should be a function.
I'd go with: isInlineStyle()
<span class="quote">> Source/WebInspectorUI/UserInterface/Models/CSSStyleSheet.js:92
> + markAsCssInlineStyle()</span >
Ditto. Go with: markAsInlineStyle().</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>