<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: richer text change notifications"
href="https://bugs.webkit.org/show_bug.cgi?id=142719#c105">Comment # 105</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: richer text change notifications"
href="https://bugs.webkit.org/show_bug.cgi?id=142719">bug 142719</a>
from <span class="vcard"><a class="email" href="mailto:d_russell@apple.com" title="Doug Russell <d_russell@apple.com>"> <span class="fn">Doug Russell</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=142719#c104">comment #104</a>)
<span class="quote">> > > Source/WebCore/editing/ReplaceInsertIntoTextNodeCommand.h:37
> > > + static Ref<ReplaceInsertIntoTextNodeCommand> create(PassRefPtr<Text> node, unsigned offset, const String& text, const String& deletedText, EditAction editingAction)
> >
> > New code should not use PassRefPtr. See
> > <<a href="https://www.webkit.org/coding/RefPtr.html">https://www.webkit.org/coding/RefPtr.html</a>>.
> >
> > > Source/WebCore/editing/ReplaceInsertIntoTextNodeCommand.h:43
> > > + ReplaceInsertIntoTextNodeCommand(PassRefPtr<Text>, unsigned, const String&, const String&, EditAction);
> >
> > New code should not use PassRefPtr. See
> > <<a href="https://www.webkit.org/coding/RefPtr.html">https://www.webkit.org/coding/RefPtr.html</a>>.
>
> Switching these methods to RefPtr results in style errors:
> ERROR: Source/WebCore/editing/ReplaceDeleteFromTextNodeCommand.cpp:33: The
> parameter type should use PassRefPtr instead of RefPtr.
> [readability/pass_ptr] [5]
>
> What's the appropriate type here?</span >
Nevermind, didn't have a &&
<span class="quote">> Function arguments
> If a function does not take ownership of an object, the argument should be a raw reference or raw pointer.
> If a function does take ownership of an object, the argument should be a Ref&& or a RefPtr&&. This includes many setter functions.</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>