<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [UNIX] Do not allow copies of IPC::Attachment"
href="https://bugs.webkit.org/show_bug.cgi?id=144096">bug 144096</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #251427 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [UNIX] Do not allow copies of IPC::Attachment"
href="https://bugs.webkit.org/show_bug.cgi?id=144096#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [UNIX] Do not allow copies of IPC::Attachment"
href="https://bugs.webkit.org/show_bug.cgi?id=144096">bug 144096</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=251427&action=diff" name="attach_251427" title="Patch">attachment 251427</a> <a href="attachment.cgi?id=251427&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=251427&action=review">https://bugs.webkit.org/attachment.cgi?id=251427&action=review</a>
This is OK, but could be improved.
<span class="quote">> Source/WebKit2/Platform/IPC/ArgumentDecoder.cpp:217
> + attachment = WTF::move(m_attachments.last());
> m_attachments.removeLast();</span >
Should instead be:
attachment = m_attachments.takeLast();
<span class="quote">> Source/WebKit2/Platform/IPC/Attachment.cpp:59
> + encoder.addAttachment(Attachment(*this));
> +#if USE(UNIX_DOMAIN_SOCKETS)
> + // The encoder takes the onwership of our file descriptor.
> + m_fileDescriptor = -1;
> +#endif</span >
Should instead be:
encoding.addAttachment(WTF::move(*this));
<span class="quote">> Source/WebKit2/Platform/IPC/Attachment.h:85
> + Attachment(const Attachment&) = default;
> + Attachment& operator=(Attachment&) = default;</span >
Why default? Why not delete? I think this is only needed because of the incorrect code in Attachment::encode.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>