<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add PerfAutoRun to automate browser based performance benchmarks(e.g. Speedometer and JetStream)"
href="https://bugs.webkit.org/show_bug.cgi?id=144038#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add PerfAutoRun to automate browser based performance benchmarks(e.g. Speedometer and JetStream)"
href="https://bugs.webkit.org/show_bug.cgi?id=144038">bug 144038</a>
from <span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=251306&action=diff" name="attach_251306" title="Patch">attachment 251306</a> <a href="attachment.cgi?id=251306&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=251306&action=review">https://bugs.webkit.org/attachment.cgi?id=251306&action=review</a>
<span class="quote">> Tools/Scripts/PerfAutoRun/Patches/Speedometer.patch:74
> ++ console.log(dict);</span >
debug? Do we want to keep this?
<span class="quote">> Tools/Scripts/PerfAutoRun/Patches/Speedometer.patch:85
> ++ var http = new XMLHttpRequest();</span >
xhr is a better name.
<span class="quote">> Tools/Scripts/PerfAutoRun/Patches/Speedometer.patch:86
> ++ var url = '/report';</span >
unnecessary variable
<span class="quote">> Tools/Scripts/PerfAutoRun/Patches/Speedometer.patch:87
> ++ http.open("POST", url, true);</span >
true can be omitted.
<span class="quote">> Tools/Scripts/PerfAutoRun/Patches/Speedometer.patch:94
> ++ if(http.readyState == 4 && http.status == 200) {</span >
XMLHttpRequest.DONE
<span class="quote">> Tools/Scripts/PerfAutoRun/Patches/Speedometer.patch:95
> ++ closeRequest = new XMLHttpRequest();</span >
missing var
<span class="quote">> Tools/Scripts/PerfAutoRun/PerfAutoRun.py:2
> +# coding : utf-8</span >
I don't think we usually have this in our scripts.
<span class="quote">> Tools/Scripts/PerfAutoRun/PerfAutoRun.py:3
> +import argparse</span >
A blank line before the imports would be nicer IMHO.
<span class="quote">> Tools/Scripts/PerfAutoRun/PerfAutoRun.py:29
> + 'OSX',</span >
For command line arguments, I think it would be nice to avoid capital letters.
<span class="quote">> Tools/Scripts/PerfAutoRun/PerfAutoRun.py:33
> + # should we add chrome as an option? Well, chrome uses webkit in iOS.</span >
# FIXME: Should we...
(extra FIXME: and capital letter)
<span class="quote">> Tools/Scripts/PerfAutoRun/PerfAutoRun.py:39
> + 'Safari',</span >
For command line arguments, I think it would be nice to avoid capital letters.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>