<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add PerfAutoRun to automate browser based performance benchmarks(e.g. Speedometer and JetStream)"
href="https://bugs.webkit.org/show_bug.cgi?id=144038#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add PerfAutoRun to automate browser based performance benchmarks(e.g. Speedometer and JetStream)"
href="https://bugs.webkit.org/show_bug.cgi?id=144038">bug 144038</a>
from <span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=251306&action=diff" name="attach_251306" title="Patch">attachment 251306</a> <a href="attachment.cgi?id=251306&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=251306&action=review">https://bugs.webkit.org/attachment.cgi?id=251306&action=review</a>
<span class="quote">> Tools/Scripts/PerfAutoRun/README.md:54
> +* **path/to/browser/directory**: should be the folder contains the executable binary(e.g. /Application/ in OSX which contains Safari.app)</span >
s/contains/containing/
missing space before parenthesis.
s/in OSX/on OSX/
<span class="quote">> Tools/Scripts/PerfAutoRun/README.md:58
> +To create a plan, you may need to refer to Plans/jetstream.plan.</span >
s/may need to refer/may refer/
<span class="quote">> Tools/Scripts/PerfAutoRun/README.md:80
> + * **count**: the number of times you want to execute benchmark</span >
s/to execute benchmark/to run the benchmark./
<span class="quote">> Tools/Scripts/PerfAutoRun/README.md:81
> + * **original_benchmark**: a relative path of benchmark to the root of this project ('PerfAutoRun' directory)</span >
Path of the benchmark, relative to the root of this project.
<span class="quote">> Tools/Scripts/PerfAutoRun/README.md:82
> + * **benchmark_path**: (**OPTIONAL**) a relative path of patch to the root of this project ('PerfAutoRun' directory)</span >
Path of patch to apply, relative to the root of this project.
<span class="quote">> Tools/Scripts/PerfAutoRun/README.md:83
> + * **entry_point**: the relative url you want browser to launch(a relative path to the webroot)</span >
Missing space before parenthesis.
<span class="quote">> Tools/Scripts/PerfAutoRun/README.md:84
> + * **result_wrapper**: the wrapper module you want to wrap the results. Current availble option is "MergeResultWrapper". To customize your own result wrapper, extends Utilities/ResultWrapper/BaseResultWrapper.py and register your module in Utilities/ResultWrapper/ResultWrapper.json</span >
typo: availble
<span class="quote">> Tools/Scripts/PerfAutoRun/README.md:85
> + * **output_file**: specifiy the output file</span >
Typo: specifiy
<span class="quote">> Tools/Scripts/PerfAutoRun/README.md:89
> + * when you launch the page('entry_point' in benchmark), the test will start automatically</span >
Missing space before parenthesis.
<span class="quote">> Tools/Scripts/PerfAutoRun/README.md:93
> + var http = new XMLHttpRequest();</span >
same comments as before for this XHR code sample.
<span class="quote">> Tools/Scripts/PerfAutoRun/README.md:108
> +* create a patch file against original file</span >
Missing capital letter.
<span class="quote">> Tools/Scripts/PerfAutoRun/README.md:109
> + * Go to the directory contains the benchmark directory(e.g. for JetStream, you should go to PerformaceTest folder)</span >
Missing space before parenthesis.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>