<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [CMake] Clean up JSC JIT options"
href="https://bugs.webkit.org/show_bug.cgi?id=143998#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [CMake] Clean up JSC JIT options"
href="https://bugs.webkit.org/show_bug.cgi?id=143998">bug 143998</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Note, this patch in its current form is part of a long chain of patches (hence no r? yet), and needs to be committed alongside the patch in <a class="bz_bug_link
bz_status_NEW "
title="NEW - [CMake] Autogenerate cmakeconfig.h.cmake"
href="show_bug.cgi?id=143997">bug #143997</a> (or changed to not depend on that). Also note I don't touch the Xcode files here in an attempt to not break anything on Macs, only the CMake files, since they did not already have an ENABLE_JIT option. That would be a good follow-up.
I did remove the option from FeatureList.pm, since I think that won't break anything.
Alternative: remove the ENABLE_JIT option from the CMake port, and keep just ENABLE_LLINT_C_LOOP. I thought ENABLE_JIT was a nicer option to present to users, but the Xcode files and FeatureList.pm have ENABLE_LLINT_C_LOOP but not ENABLE_JIT, so this would make things consistent between both ports without requiring changes anywhere but the CMake files.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>