<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - REGRESSION (r182899): icloud.com crashes"
   href="https://bugs.webkit.org/show_bug.cgi?id=143960#c10">Comment # 10</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - REGRESSION (r182899): icloud.com crashes"
   href="https://bugs.webkit.org/show_bug.cgi?id=143960">bug 143960</a>
              from <span class="vcard"><a class="email" href="mailto:fpizlo&#64;apple.com" title="Filip Pizlo &lt;fpizlo&#64;apple.com&gt;"> <span class="fn">Filip Pizlo</span></a>
</span></b>
        <pre>(In reply to <a href="show_bug.cgi?id=143960#c9">comment #9</a>)
<span class="quote">&gt; (In reply to <a href="show_bug.cgi?id=143960#c7">comment #7</a>)
&gt; &gt; Comment on <span class=""><a href="attachment.cgi?id=251211&amp;action=diff" name="attach_251211" title="Slow (but clean) patch">attachment 251211</a> <a href="attachment.cgi?id=251211&amp;action=edit" title="Slow (but clean) patch">[details]</a></span>
&gt; &gt; Slow (but clean) patch
&gt; &gt; 
&gt; &gt; View in context:
&gt; &gt; <a href="https://bugs.webkit.org/attachment.cgi?id=251211&amp;action=review">https://bugs.webkit.org/attachment.cgi?id=251211&amp;action=review</a>
&gt; &gt; 
&gt; &gt; It's surprising that this patch is a slow-down. :-/
&gt; &gt; 
&gt; &gt; &gt; Source/JavaScriptCore/dfg/DFGWatchpointCollectionPhase.cpp:116
&gt; &gt; &gt; -        case AllocationProfileWatchpoint:
&gt; &gt; &gt; -            addLazily(m_node-&gt;castOperand&lt;JSFunction*&gt;()-&gt;allocationProfileWatchpointSet());
&gt; &gt; &gt; +        case AllocationProfileWatchpoint: {
&gt; &gt; &gt; +            InlineWatchpointSet* watchpointSet = m_node-&gt;castOperand&lt;JSFunction*&gt;()-&gt;allocationProfileWatchpointSet();
&gt; &gt; &gt; +            // If we reach this point, the function's rare data was allocated when the AllocationProfileWatchpoint
&gt; &gt; &gt; +            // was added to the graph. We never de-allocate the rare data, so it must still be present, and the
&gt; &gt; &gt; +            // allocationProfileWatchpointSet with it.
&gt; &gt; &gt; +            ASSERT (watchpointSet);
&gt; &gt; &gt; +            addLazily(*watchpointSet);
&gt; &gt; &gt;              break;
&gt; &gt; &gt; +        }
&gt; &gt; 
&gt; &gt; It would be better to remove the AllocationProfileWatchpoint node in this
&gt; &gt; patch, and do the watchpoint set registration in ByteCodeParser.
&gt; 
&gt; I thought we said we shouldn't do this?
&gt; 
&gt; (Splitting this into smaller more atomic patches)</span >

Ah - it makes sense to do that as a different patch, if you like.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>