<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION (r182899): icloud.com crashes"
href="https://bugs.webkit.org/show_bug.cgi?id=143960#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION (r182899): icloud.com crashes"
href="https://bugs.webkit.org/show_bug.cgi?id=143960">bug 143960</a>
from <span class="vcard"><a class="email" href="mailto:basile_clement@apple.com" title="Basile Clement <basile_clement@apple.com>"> <span class="fn">Basile Clement</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=143960#c7">comment #7</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=251211&action=diff" name="attach_251211" title="Slow (but clean) patch">attachment 251211</a> <a href="attachment.cgi?id=251211&action=edit" title="Slow (but clean) patch">[details]</a></span>
> Slow (but clean) patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=251211&action=review">https://bugs.webkit.org/attachment.cgi?id=251211&action=review</a>
>
> It's surprising that this patch is a slow-down. :-/
>
> > Source/JavaScriptCore/dfg/DFGWatchpointCollectionPhase.cpp:116
> > - case AllocationProfileWatchpoint:
> > - addLazily(m_node->castOperand<JSFunction*>()->allocationProfileWatchpointSet());
> > + case AllocationProfileWatchpoint: {
> > + InlineWatchpointSet* watchpointSet = m_node->castOperand<JSFunction*>()->allocationProfileWatchpointSet();
> > + // If we reach this point, the function's rare data was allocated when the AllocationProfileWatchpoint
> > + // was added to the graph. We never de-allocate the rare data, so it must still be present, and the
> > + // allocationProfileWatchpointSet with it.
> > + ASSERT (watchpointSet);
> > + addLazily(*watchpointSet);
> > break;
> > + }
>
> It would be better to remove the AllocationProfileWatchpoint node in this
> patch, and do the watchpoint set registration in ByteCodeParser.</span >
I thought we said we shouldn't do this?
(Splitting this into smaller more atomic patches)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>