<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - Many test failures in scm_unittest.py"
href="https://bugs.webkit.org/show_bug.cgi?id=143967">143967</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>Many test failures in scm_unittest.py
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>528+ (Nightly build)
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>Linux
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>Tools / Tests
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>mcatanzaro@igalia.com
</td>
</tr></table>
<p>
<div>
<pre>Looks like scm_unittest.py has not been updated in a while. I see many failures:
$ test-webkitpy --all
Suppressing most webkitpy logging while running unit tests.
[47/1550] webkitpy.common.checkout.scm.s..._files_local_plus_working_copy erred:
Traceback (most recent call last):
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 1409, in test_changed_files_local_plus_working_copy
files = self.scm.changed_files('trunk..')
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py", line 223, in changed_files
return self.run_status_and_extract_filenames(status_command, self._status_regexp("ADM"))
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py", line 88, in run_status_and_extract_filenames
for line in self.run(status_command, cwd=self.checkout_root).splitlines():
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py", line 78, in run
decode_output=decode_output)
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 456, in run_command
(error_handler or self.default_error_handler)(script_error)
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 374, in default_error_handler
raise error
ScriptError: Failed to run "['git', 'diff', '-r', '--name-status', '--no-renames', '--no-ext-diff', '--full-index', 'trunk..', '.']" exit_code: 128 cwd: /tmp/tmpNGh_3sgit_test_checkout
[49/1550] webkitpy.common.checkout.scm.s....test_changed_files_not_synced erred:
Traceback (most recent call last):
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 1452, in test_changed_files_not_synced
run_command(['git', 'checkout', '-b', 'my-branch', 'trunk~3'])
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 85, in run_command
return Executive().run_command(*args, **kwargs)
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 456, in run_command
(error_handler or self.default_error_handler)(script_error)
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 374, in default_error_handler
raise error
ScriptError: Failed to run "['git', 'checkout', '-b', 'my-branch', 'trunk~3']" exit_code: 128
[56/1550] webkitpy.common.checkout.scm.s...commit_with_message_not_synced erred:
Traceback (most recent call last):
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 1273, in test_commit_with_message_not_synced
run_command(['git', 'checkout', '-b', 'my-branch', 'trunk~3'])
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 85, in run_command
return Executive().run_command(*args, **kwargs)
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 456, in run_command
(error_handler or self.default_error_handler)(script_error)
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 374, in default_error_handler
raise error
ScriptError: Failed to run "['git', 'checkout', '-b', 'my-branch', 'trunk~3']" exit_code: 128
[58/1550] webkitpy.common.checkout.scm.s...ssage_not_synced_with_conflict erred:
Traceback (most recent call last):
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 1286, in test_commit_with_message_not_synced_with_conflict
run_command(['git', 'checkout', '-b', 'my-branch', 'trunk~3'])
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 85, in run_command
return Executive().run_command(*args, **kwargs)
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 456, in run_command
(error_handler or self.default_error_handler)(script_error)
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 374, in default_error_handler
raise error
ScriptError: Failed to run "['git', 'checkout', '-b', 'my-branch', 'trunk~3']" exit_code: 128
[68/1550] webkitpy.common.checkout.scm.s....test_create_patch_after_merge erred:
Traceback (most recent call last):
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 1323, in test_create_patch_after_merge
run_command(['git', 'checkout', '-b', 'dummy-branch', 'trunk~3'])
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 85, in run_command
return Executive().run_command(*args, **kwargs)
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 456, in run_command
(error_handler or self.default_error_handler)(script_error)
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 374, in default_error_handler
raise error
ScriptError: Failed to run "['git', 'checkout', '-b', 'dummy-branch', 'trunk~3']" exit_code: 128
[75/1550] webkitpy.common.checkout.scm.s...t.test_create_patch_not_synced erred:
Traceback (most recent call last):
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 1369, in test_create_patch_not_synced
run_command(['git', 'checkout', '-b', 'my-branch', 'trunk~3'])
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 85, in run_command
return Executive().run_command(*args, **kwargs)
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 456, in run_command
(error_handler or self.default_error_handler)(script_error)
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 374, in default_error_handler
raise error
ScriptError: Failed to run "['git', 'checkout', '-b', 'my-branch', 'trunk~3']" exit_code: 128
[93/1550] webkitpy.common.checkout.scm....SVNTest.test_remote_branch_ref failed:
Traceback (most recent call last):
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 1298, in test_remote_branch_ref
self.assertEqual(self.scm.remote_branch_ref(), 'refs/remotes/trunk')
AssertionError: u'refs/remotes/origin/trunk' != 'refs/remotes/trunk'
[104/1550] webkitpy.common.checkout.scm....TestWithMock.test_create_patch erred:
Traceback (most recent call last):
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 1569, in test_create_patch
scm = self.make_scm(logging_executive=True)
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 1563, in make_scm
scm = Git(cwd=".", executive=MockExecutive(), filesystem=MockFileSystem())
TypeError: __init__() takes exactly 3 arguments (2 given)
[105/1550] webkitpy.common.checkout.scm....ver_with_username_and_password erred:
Traceback (most recent call last):
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 1579, in test_push_local_commits_to_server_with_username_and_password
self.assertEqual(self.make_scm().push_local_commits_to_server(username='<a href="mailto:dbates@webkit.org">dbates@webkit.org</a>', password='blah'), "MOCK output of child process")
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 1563, in make_scm
scm = Git(cwd=".", executive=MockExecutive(), filesystem=MockFileSystem())
TypeError: __init__() takes exactly 3 arguments (2 given)
[106/1550] webkitpy.common.checkout.scm...._username_and_without_password erred:
Traceback (most recent call last):
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 1585, in test_push_local_commits_to_server_with_username_and_without_password
self.assertRaises(AuthenticationError, self.make_scm().push_local_commits_to_server, {'username': '<a href="mailto:dbates@webkit.org">dbates@webkit.org</a>'})
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 1563, in make_scm
scm = Git(cwd=".", executive=MockExecutive(), filesystem=MockFileSystem())
TypeError: __init__() takes exactly 3 arguments (2 given)
[107/1550] webkitpy.common.checkout.scm...._without_username_and_password erred:
Traceback (most recent call last):
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 1582, in test_push_local_commits_to_server_without_username_and_password
self.assertRaises(AuthenticationError, self.make_scm().push_local_commits_to_server)
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 1563, in make_scm
scm = Git(cwd=".", executive=MockExecutive(), filesystem=MockFileSystem())
TypeError: __init__() takes exactly 3 arguments (2 given)
[108/1550] webkitpy.common.checkout.scm....out_username_and_with_password erred:
Traceback (most recent call last):
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 1588, in test_push_local_commits_to_server_without_username_and_with_password
self.assertRaises(AuthenticationError, self.make_scm().push_local_commits_to_server, {'password': 'blah'})
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 1563, in make_scm
scm = Git(cwd=".", executive=MockExecutive(), filesystem=MockFileSystem())
TypeError: __init__() takes exactly 3 arguments (2 given)
[109/1550] webkitpy.common.checkout.scm....ock.test_timestamp_of_revision erred:
Traceback (most recent call last):
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 1591, in test_timestamp_of_revision
scm = self.make_scm()
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 1563, in make_scm
scm = Git(cwd=".", executive=MockExecutive(), filesystem=MockFileSystem())
TypeError: __init__() takes exactly 3 arguments (2 given)
[1017/1550] webkitpy.thirdparty.__init___...t.ThirdpartyTest.test_imports erred:
Traceback (most recent call last):
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/thirdparty/__init___unittest.py", line 62, in test_imports
import webkitpy.thirdparty.autoinstalled.coverage
File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/coverage/__init__.py", line 15, in <module>
from coverage.control import coverage, process_startup
ImportError: cannot import name coverage
Ran 1550 tests in 13.943s
FAILED (failures=1, errors=13)
Half of them seem to be that GitTestWithMock.make_scm() passes too few arguments to the Git() constructor. The other half seem to reference a commit named trunk, which has no meaning in git.
This is with git 2.3.5.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>