<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Add initial implementation of NetworkProcess disk cache"
href="https://bugs.webkit.org/show_bug.cgi?id=143872#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Add initial implementation of NetworkProcess disk cache"
href="https://bugs.webkit.org/show_bug.cgi?id=143872">bug 143872</a>
from <span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=251014&action=diff" name="attach_251014" title="Patch">attachment 251014</a> <a href="attachment.cgi?id=251014&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=251014&action=review">https://bugs.webkit.org/attachment.cgi?id=251014&action=review</a>
<span class="quote">> Source/WebKit2/NetworkProcess/cache/NetworkCacheData.h:114
> + Data(SoupBuffer*, Backing = Backing::Buffer);</span >
Could this be a GRefPtr<SourceBuffer>&& to make memory management clearer?
<span class="quote">> Source/WebKit2/NetworkProcess/cache/NetworkCacheDataSoup.cpp:56
> + return { buffer.get() };</span >
then this would be a return { WTF::move(buffer) };</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>