<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:fpizlo@apple.com" title="Filip Pizlo <fpizlo@apple.com>"> <span class="fn">Filip Pizlo</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Extract the allocation profile from JSFunction into a rare object"
href="https://bugs.webkit.org/show_bug.cgi?id=143807">bug 143807</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #250928 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Extract the allocation profile from JSFunction into a rare object"
href="https://bugs.webkit.org/show_bug.cgi?id=143807#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Extract the allocation profile from JSFunction into a rare object"
href="https://bugs.webkit.org/show_bug.cgi?id=143807">bug 143807</a>
from <span class="vcard"><a class="email" href="mailto:fpizlo@apple.com" title="Filip Pizlo <fpizlo@apple.com>"> <span class="fn">Filip Pizlo</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=250928&action=diff" name="attach_250928" title="Hopefully final patch">attachment 250928</a> <a href="attachment.cgi?id=250928&action=edit" title="Hopefully final patch">[details]</a></span>
Hopefully final patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=250928&action=review">https://bugs.webkit.org/attachment.cgi?id=250928&action=review</a>
Looks great! Please change the license and reupload. Then I can mark cq+.
<span class="quote">> Source/JavaScriptCore/runtime/FunctionRareData.cpp:19
> +/*
> + * Copyright (C) 2015 Apple Inc. All rights reserved.
> + *
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Library General Public
> + * License as published by the Free Software Foundation; either
> + * version 2 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + * Library General Public License for more details.
> + *
> + * You should have received a copy of the GNU Library General Public License
> + * along with this library; see the file COPYING.LIB. If not, write to
> + * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
> + * Boston, MA 02110-1301, USA.
> + *
> + */</span >
Newly created files should use the 2-clause BSD license: <a href="https://www.webkit.org/coding/bsd-license.html">https://www.webkit.org/coding/bsd-license.html</a>
<span class="quote">> Source/JavaScriptCore/runtime/FunctionRareData.h:19
> +/*
> + * Copyright (C) 2015 Apple Inc. All rights reserved.
> + *
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Library General Public
> + * License as published by the Free Software Foundation; either
> + * version 2 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + * Library General Public License for more details.
> + *
> + * You should have received a copy of the GNU Library General Public License
> + * along with this library; see the file COPYING.LIB. If not, write to
> + * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
> + * Boston, MA 02110-1301, USA.
> + *
> + */</span >
Ditto.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>