<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Use UNUSED_PARAM instead of the void casting to suppress unused parameter warnings"
href="https://bugs.webkit.org/show_bug.cgi?id=143750">bug 143750</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #250795 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Use UNUSED_PARAM instead of the void casting to suppress unused parameter warnings"
href="https://bugs.webkit.org/show_bug.cgi?id=143750#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Use UNUSED_PARAM instead of the void casting to suppress unused parameter warnings"
href="https://bugs.webkit.org/show_bug.cgi?id=143750">bug 143750</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=250795&action=diff" name="attach_250795" title="Patch">attachment 250795</a> <a href="attachment.cgi?id=250795&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=250795&action=review">https://bugs.webkit.org/attachment.cgi?id=250795&action=review</a>
I’m OK with this as is, but it doesn’t really seem like much of an improvement.
<span class="quote">> Source/WebKit2/WebProcess/Notifications/NotificationPermissionRequestManager.cpp:67
> NotificationPermissionRequestManager::NotificationPermissionRequestManager(WebPage* page)
> +{
> #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
> - : m_page(page)
> + m_page = page;
> +#else
> + UNUSED_PARAM(page);
> #endif
> -{
> - (void)page;
> }</span >
I don’t really like the way this changes from initialization syntax to assignment syntax. I’d prefer to avoid both UNUSED_PARAM and (void) myself by just repeating the function twice:
#if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
NotificationPermissionRequestManager::NotificationPermissionRequestManager(WebPage* page)
: m_page(page)
{
}
#else
NotificationPermissionRequestManager::NotificationPermissionRequestManager(WebPage*)
{
}
#endif
One nice thing about that is that it clears the way for further refinement, for example, we could make the empty constructor inline by putting it in the header and marking it inline without making the non-empty constructor be inlined.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>