<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Use UNUSED_PARAM instead of the void casting to suppress unused parameter warnings"
href="https://bugs.webkit.org/show_bug.cgi?id=143750#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Use UNUSED_PARAM instead of the void casting to suppress unused parameter warnings"
href="https://bugs.webkit.org/show_bug.cgi?id=143750">bug 143750</a>
from <span class="vcard"><a class="email" href="mailto:sungmann.cho@navercorp.com" title="Sungmann Cho <sungmann.cho@navercorp.com>"> <span class="fn">Sungmann Cho</span></a>
</span></b>
<pre>Addressed your comments.(In reply to <a href="show_bug.cgi?id=143750#c12">comment #12</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=143750#c10">comment #10</a>)
> > (In reply to <a href="show_bug.cgi?id=143750#c7">comment #7</a>)
> > > Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=250791&action=diff" name="attach_250791" title="Patch">attachment 250791</a> <a href="attachment.cgi?id=250791&action=edit" title="Patch">[details]</a></span>
> > > Patch
> > >
> > > Ouch, it's so ugly. :-/ Unfortunately we can't put UNUSED_PARAM to the same
> > > place as init list.
> > >
> > > I think this one would be the least ugly solution
> > >
> > > NotificationPermissionRequestManager::
> > > NotificationPermissionRequestManager(WebPage* page)
> > > {
> > > #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
> > > m_page = page
> > > #else
> > > UNUSED_PARAM(page);
> > > #endif
> > > }
> >
> > Agreed. But the member initialization is slightly different from the
> > assignment.
> > Any thoughts on this?
>
> I think biggest difference is generally that copy constructor of *WebPage*
> class is called or not. In this case, however, m_page is a pointer type of
> *WebPage*. Thus it seems to me that there is no big difference between both.</span >
(In reply to <a href="show_bug.cgi?id=143750#c12">comment #12</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=143750#c10">comment #10</a>)
> > (In reply to <a href="show_bug.cgi?id=143750#c7">comment #7</a>)
> > > Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=250791&action=diff" name="attach_250791" title="Patch">attachment 250791</a> <a href="attachment.cgi?id=250791&action=edit" title="Patch">[details]</a></span>
> > > Patch
> > >
> > > Ouch, it's so ugly. :-/ Unfortunately we can't put UNUSED_PARAM to the same
> > > place as init list.
> > >
> > > I think this one would be the least ugly solution
> > >
> > > NotificationPermissionRequestManager::
> > > NotificationPermissionRequestManager(WebPage* page)
> > > {
> > > #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
> > > m_page = page
> > > #else
> > > UNUSED_PARAM(page);
> > > #endif
> > > }
> >
> > Agreed. But the member initialization is slightly different from the
> > assignment.
> > Any thoughts on this?
>
> I think biggest difference is generally that copy constructor of *WebPage*
> class is called or not. In this case, however, m_page is a pointer type of
> *WebPage*. Thus it seems to me that there is no big difference between both.</span >
I addressed your comments. Thanks!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>