<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ossy@webkit.org" title="Csaba Osztrogonác <ossy@webkit.org>"> <span class="fn">Csaba Osztrogonác</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [W32] weakCompareAndSwap assembler code is not used when building with MinGW GCC"
href="https://bugs.webkit.org/show_bug.cgi?id=143754">bug 143754</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #250789 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [W32] weakCompareAndSwap assembler code is not used when building with MinGW GCC"
href="https://bugs.webkit.org/show_bug.cgi?id=143754#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [W32] weakCompareAndSwap assembler code is not used when building with MinGW GCC"
href="https://bugs.webkit.org/show_bug.cgi?id=143754">bug 143754</a>
from <span class="vcard"><a class="email" href="mailto:ossy@webkit.org" title="Csaba Osztrogonác <ossy@webkit.org>"> <span class="fn">Csaba Osztrogonác</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=250789&action=diff" name="attach_250789" title="[GTK][W32] Allow MinGW-GCC to use GCC asm code for weakCompareAndSwap">attachment 250789</a> <a href="attachment.cgi?id=250789&action=edit" title="[GTK][W32] Allow MinGW-GCC to use GCC asm code for weakCompareAndSwap">[details]</a></span>
[GTK][W32] Allow MinGW-GCC to use GCC asm code for weakCompareAndSwap
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=250789&action=review">https://bugs.webkit.org/attachment.cgi?id=250789&action=review</a>
<span class="quote">> Source/JavaScriptCore/ChangeLog:8
> + [W32] Fixup dummy HeapStatistics implementation
> +
> + GCC warns that exitWithFailure is marked as noreturn, but it does return:
> + ../webkitgtk-2.4.8/Source/JavaScriptCore/heap/HeapStatistics.cpp:135:1: warning: 'noreturn' function does return
> +
> + Call exit(-1) to indicate that no, there is no returning from here.</span >
It is unrelated to this patch.
<span class="quote">> Source/JavaScriptCore/ChangeLog:16
> + * heap/HeapStatistics.cpp:
> + (JSC::HeapStatistics::exitWithFailure):</span >
ditto
<span class="quote">> Source/WTF/wtf/Atomics.h:263
> -#if !OS(WINDOWS) && (CPU(X86) || CPU(X86_64))
> +#if (!OS(WINDOWS) || COMPILER(GCC)) && (CPU(X86) || CPU(X86_64))</span >
I think OS(WINDOWS) is very confusing and isn't good at all,
COMPILER(GCC) && (CPU(X86) || CPU(X86_64)) would be better.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>