<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Use UNUSED_PARAM instead of the void casting to suppress unused parameter warnings"
href="https://bugs.webkit.org/show_bug.cgi?id=143750#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Use UNUSED_PARAM instead of the void casting to suppress unused parameter warnings"
href="https://bugs.webkit.org/show_bug.cgi?id=143750">bug 143750</a>
from <span class="vcard"><a class="email" href="mailto:ossy@webkit.org" title="Csaba Osztrogonác <ossy@webkit.org>"> <span class="fn">Csaba Osztrogonác</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=143750#c6">comment #6</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=250791&action=diff" name="attach_250791" title="Patch">attachment 250791</a> <a href="attachment.cgi?id=250791&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=250791&action=review">https://bugs.webkit.org/attachment.cgi?id=250791&action=review</a>
>
> > Source/WebKit2/WebProcess/Notifications/NotificationPermissionRequestManager.cpp:65
> > +#if !ENABLE(NOTIFICATIONS) && !ENABLE(LEGACY_NOTIFICATIONS)
>
> I don't like to use unnecessary macro. Probably it looks Ossy wants to use a
> thing similar to below style.
>
> NotificationPermissionRequestManager::
> NotificationPermissionRequestManager(WebPage* page)
> {
> #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
> m_page = page;
> #else
> UNUSED_PARAM(page);
> #endif
> }</span >
haha, you must be a thought-reader :)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>