<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Network Cache: Deduplicate body data"
href="https://bugs.webkit.org/show_bug.cgi?id=143652">bug 143652</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #250632 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Network Cache: Deduplicate body data"
href="https://bugs.webkit.org/show_bug.cgi?id=143652#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Network Cache: Deduplicate body data"
href="https://bugs.webkit.org/show_bug.cgi?id=143652">bug 143652</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=250632&action=diff" name="attach_250632" title="patch">attachment 250632</a> <a href="attachment.cgi?id=250632&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=250632&action=review">https://bugs.webkit.org/attachment.cgi?id=250632&action=review</a>
<span class="quote">> Source/WebKit2/NetworkProcess/cache/NetworkCacheBlobStorage.cpp:155
> + return stat.st_nlink - 1;</span >
Any danger of using more links to a single file than the file system supports?
<span class="quote">> Source/WebKit2/NetworkProcess/cache/NetworkCacheBlobStorage.h:35
> +#include <wtf/text/WTFString.h></span >
Don’t need this include.
<span class="quote">> Source/WebKit2/NetworkProcess/cache/NetworkCacheBlobStorage.h:50
> + // These are all synchronous and should not be used from the main thread.</span >
This comment applies to the constructor of the class too!
<span class="quote">> Source/WebKit2/NetworkProcess/cache/NetworkCacheBlobStorage.h:66
> + const CString m_blobDirectoryPath;</span >
Don’t we have thread safety issues with the reference count of this data member? I don’t understand the threading restrictions on this class. Maybe the only function that is safe to call on another thread is approximateSize()?
<span class="quote">> Source/WebKit2/NetworkProcess/cache/NetworkCacheData.h:135
> +Data mapFile(const CString& path);</span >
Unusual style to take a const CString&; wouldn’t we normally take const char* instead?
<span class="quote">> Source/WebKit2/NetworkProcess/cache/NetworkCacheDataCocoa.mm:148
> + if (a.isNull() || b.isNull())
> + return false;</span >
So null != null? Is that really what we want?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>