<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Disable Linux-specific code in a Windows build"
href="https://bugs.webkit.org/show_bug.cgi?id=137973#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Disable Linux-specific code in a Windows build"
href="https://bugs.webkit.org/show_bug.cgi?id=137973">bug 137973</a>
from <span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=137973#c10">comment #10</a>)
<span class="quote">> Created <span class=""><a href="attachment.cgi?id=250497&action=diff" name="attach_250497" title="proposed wk patch IV">attachment 250497</a> <a href="attachment.cgi?id=250497&action=edit" title="proposed wk patch IV">[details]</a></span>
> proposed wk patch IV
>
> Updated webkit patch with the suggested changes applied. I agree with both.</span >
(In reply to <a href="show_bug.cgi?id=137973#c11">comment #11</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=137973#c9">comment #9</a>)
> > This should probably be:
> >
> > #if OS(DARWIN) || (OS(LINUX) && !PLATFORM(GTK))
> >
> > Same up above in the includes. Do you agree?
>
> Hmm, thinking of it, this will disable backtraces for any GTK platform
> build, not only for those which do not support it, like those not having
> dlfcn.h and execinfo.h.</span >
I believe this code is only reachable through ENABLE_REMOTE_INSPECTOR so it really doesn't matter ;)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>