<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Styles sidebar editing with incomplete property looks poor in UI"
href="https://bugs.webkit.org/show_bug.cgi?id=141692#c21">Comment # 21</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Styles sidebar editing with incomplete property looks poor in UI"
href="https://bugs.webkit.org/show_bug.cgi?id=141692">bug 141692</a>
from <span class="vcard"><a class="email" href="mailto:timothy@apple.com" title="Timothy Hatcher <timothy@apple.com>"> <span class="fn">Timothy Hatcher</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=250537&action=diff" name="attach_250537" title="patch">attachment 250537</a> <a href="attachment.cgi?id=250537&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=250537&action=review">https://bugs.webkit.org/attachment.cgi?id=250537&action=review</a>
I'll let Joe look at this for actual substance.
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:790
> + }
> +
> _resetContent()</span >
Nit: Extra newline.
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:853
> + });
> + return;</span >
Nit: Newline.
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:859
> + // Now the Formatter pretty prints the styles.
> + editor.setValue(this._formattedContentFromEditor());</span >
I'd put a newline before the comment.
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:896
> + this._markLinesWithCheckboxPlaceholder();
> +
> }</span >
Nit: Extra newline.
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/CodeMirrorFormatters.js:34
> + return false;
> + },</span >
Nit: Newline.
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/CodeMirrorFormatters.js:312
> + },
> shouldHaveSpaceBeforeToken: function(lastToken, lastContent, token, state, content, isComment)</span >
Ditto.
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/CodeMirrorFormatters.js:439
> + },
> + shouldHaveSpaceBeforeToken: function(lastToken, lastContent, token, state, content, isComment)</span >
Ditto.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>