<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Disable Linux-specific code in a Windows build"
href="https://bugs.webkit.org/show_bug.cgi?id=137973">bug 137973</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #240906 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Disable Linux-specific code in a Windows build"
href="https://bugs.webkit.org/show_bug.cgi?id=137973#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Disable Linux-specific code in a Windows build"
href="https://bugs.webkit.org/show_bug.cgi?id=137973">bug 137973</a>
from <span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=240906&action=diff" name="attach_240906" title="proposed wk patch ]I[">attachment 240906</a> <a href="attachment.cgi?id=240906&action=edit" title="proposed wk patch ]I[">[details]</a></span>
proposed wk patch ]I[
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=240906&action=review">https://bugs.webkit.org/attachment.cgi?id=240906&action=review</a>
<span class="quote">> Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp:152
> +#if OS(DARWIN) || (OS(LINUX) && !defined(__UCLIBC__))</span >
Based on wtf/Assertions.cpp, which has:
#if OS(DARWIN) || OS(LINUX)
# if PLATFORM(GTK)
# if defined(__GLIBC__) && !defined(__UCLIBC__)
# define WTF_USE_BACKTRACE_SYMBOLS 1
# endif
# else
# define WTF_USE_DLADDR 1
# endif
#endif
This should probably be:
#if OS(DARWIN) || (OS(LINUX) && !PLATFORM(GTK))
Same up above in the includes. Do you agree?
<span class="quote">> Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp:177
> + UNUSED_PARAM(callStack);</span >
Nit: Too much indentation.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>