<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mrobinson@webkit.org" title="Martin Robinson <mrobinson@webkit.org>"> <span class="fn">Martin Robinson</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user"
href="https://bugs.webkit.org/show_bug.cgi?id=143521">bug 143521</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #250347 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user"
href="https://bugs.webkit.org/show_bug.cgi?id=143521#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user"
href="https://bugs.webkit.org/show_bug.cgi?id=143521">bug 143521</a>
from <span class="vcard"><a class="email" href="mailto:mrobinson@webkit.org" title="Martin Robinson <mrobinson@webkit.org>"> <span class="fn">Martin Robinson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=250347&action=diff" name="attach_250347" title="Patch">attachment 250347</a> <a href="attachment.cgi?id=250347&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=250347&action=review">https://bugs.webkit.org/attachment.cgi?id=250347&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:13
> + try to remove more references that what the object actually has,</span >
Nit: that what -> than what
<span class="quote">> Source/WebCore/bindings/gobject/DOMObjectCache.cpp:48
> + cacheReferences = std::min(static_cast<unsigned>(object->ref_count), cacheReferences);</span >
It might be worth dropping a comment here explaining why cacheReferences might be incorrect at this point.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>