<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED INVALID - Crash in JSC::DFG::StackLayoutPhase::run"
href="https://bugs.webkit.org/show_bug.cgi?id=141028#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED INVALID - Crash in JSC::DFG::StackLayoutPhase::run"
href="https://bugs.webkit.org/show_bug.cgi?id=141028">bug 141028</a>
from <span class="vcard"><a class="email" href="mailto:fpizlo@apple.com" title="Filip Pizlo <fpizlo@apple.com>"> <span class="fn">Filip Pizlo</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=141028#c5">comment #5</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=245915&action=diff" name="attach_245915" title="Patch">attachment 245915</a> <a href="attachment.cgi?id=245915&action=edit" title="Patch">[details]</a></span>
> Patch
>
> Should we still take these additional regression tests, since they
> presumably cover something that was not covered before?</span >
Nah.
Previously, if you said "arguments" then the whole compiler - every compiler in every tier - would flip into this alternate reality world. So we were steadily converging towards having two versions of every test: one that said "arguments" and one that didn't.
This isn't true anymore. Saying "arguments" only changes how the arguments themselves are accessed but after bytecode generation, none of the tiers really care.
So, having tests for recursion using apply where you say "arguments" isn't really useful. There's nothing special about that anymore.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>