<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] extra-headers and keep-alive properties for HTTP source element"
href="https://bugs.webkit.org/show_bug.cgi?id=143480">bug 143480</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #250269 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] extra-headers and keep-alive properties for HTTP source element"
href="https://bugs.webkit.org/show_bug.cgi?id=143480#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] extra-headers and keep-alive properties for HTTP source element"
href="https://bugs.webkit.org/show_bug.cgi?id=143480">bug 143480</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=250269&action=diff" name="attach_250269" title="patch">attachment 250269</a> <a href="attachment.cgi?id=250269&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=250269&action=review">https://bugs.webkit.org/attachment.cgi?id=250269&action=review</a>
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/GUniquePtrGStreamer.h:35
> +template<> struct GPtrDeleter<GstStructure> {
> + void operator() (GstStructure* ptr) const
> + {
> + if (ptr)
> + gst_structure_free(ptr);
> + }
> +};</span >
I just asked if we had this already, but now that we are adding it, it would be easier to use the WTF_DEFINE_GPTR_DELETER macro.
WTF_DEFINE_GPTR_DELETER(GstStructure, gst_structure_free)
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:479
> + return FALSE;</span >
false
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:485
> + return TRUE;</span >
true
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:491
> + unsigned n = gst_value_array_get_size(value);</span >
Sorry that I missed this in my previous review, use a more descriptive name than 'n' for the variable.
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:501
> + unsigned n = gst_value_list_get_size(value);</span >
Ditto.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>