<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Improvements to webkitmouseforce web API"
href="https://bugs.webkit.org/show_bug.cgi?id=143387">bug 143387</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #250103 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Improvements to webkitmouseforce web API"
href="https://bugs.webkit.org/show_bug.cgi?id=143387#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Improvements to webkitmouseforce web API"
href="https://bugs.webkit.org/show_bug.cgi?id=143387">bug 143387</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=250103&action=diff" name="attach_250103" title="Patch">attachment 250103</a> <a href="attachment.cgi?id=250103&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=250103&action=review">https://bugs.webkit.org/attachment.cgi?id=250103&action=review</a>
<span class="quote">> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:345
> + , m_lastForceStage(0)</span >
No need to initialize here if you take my suggestion below.
<span class="quote">> Source/WebKit2/WebProcess/WebPage/WebPage.h:1348
> + int m_lastForceStage;</span >
Better to initialize this here:
int m_lastForceStage { 0 };
or even:
int m_lastForceStage { };
<span class="quote">> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:1168
> + float overallForce = stage < 1 ? force : force + stage - 1;</span >
I guess the force number is in the range [0,1]? Should we assert that?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>