<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Use std::chrono types to represent time in response and cache classes"
href="https://bugs.webkit.org/show_bug.cgi?id=143316#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Use std::chrono types to represent time in response and cache classes"
href="https://bugs.webkit.org/show_bug.cgi?id=143316">bug 143316</a>
from <span class="vcard"><a class="email" href="mailto:andersca@apple.com" title="Anders Carlsson <andersca@apple.com>"> <span class="fn">Anders Carlsson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=249979&action=diff" name="attach_249979" title="another">attachment 249979</a> <a href="attachment.cgi?id=249979&action=edit" title="another">[details]</a></span>
another
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=249979&action=review">https://bugs.webkit.org/attachment.cgi?id=249979&action=review</a>
<span class="quote">> Source/WebCore/platform/network/CacheValidation.cpp:113
> + auto maxAge = response.cacheControlMaxAge();
> + if (maxAge)</span >
Can fold this into the if condition.
<span class="quote">> Source/WebCore/platform/network/HTTPParsers.cpp:243
> + // This assumes system_clock epoch equals Unix epoch which is true for all implementations but unspecified.
> + // FIXME: The parsing function should be switched to std::chrono too.</span >
Maybe we can use std::chrono::system:clock::to_time_t or something?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>