<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Async loading of image resources"
   href="https://bugs.webkit.org/show_bug.cgi?id=134488#c59">Comment # 59</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Async loading of image resources"
   href="https://bugs.webkit.org/show_bug.cgi?id=134488">bug 134488</a>
              from <span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=249755&action=diff" name="attach_249755" title="Patch">attachment 249755</a> <a href="attachment.cgi?id=249755&action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=249755&action=review">https://bugs.webkit.org/attachment.cgi?id=249755&action=review</a>

<span class="quote">> Source/WebCore/loader/ImageLoader.cpp:72
> +    static std::unique_ptr<ImageLoaderTask> create(WeakPtr<ImageLoader> loader, bool shouldBypassMainWorldContentSecurityPolicy)</span >

nit: I think we decided to get rid of these factory methods for std::unique_ptr and use std::make_unique<>() at call sites. Note that it requires making the constructor public though.

<span class="quote">> Source/WebCore/loader/ImageLoader.h:80
> +    bool pendingTask() const { return m_pendingTask; }</span >

for booleans, we prefer names that start with "is" or "has", in this case, hasPendingTask() / m_hasPendingTask would be nicer.

<span class="quote">> Source/WebCore/loader/ImageLoader.h:109
> +    bool shouldLoadImmediately(const AtomicString&) const;</span >

I don't think we should omit the argument name here as it is not obvious what it is.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>