<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Use std::unique_ptr instead of PassOwnPtr|OwnPtr for ResourceResponse"
   href="https://bugs.webkit.org/show_bug.cgi?id=143056#c4">Comment # 4</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Use std::unique_ptr instead of PassOwnPtr|OwnPtr for ResourceResponse"
   href="https://bugs.webkit.org/show_bug.cgi?id=143056">bug 143056</a>
              from <span class="vcard"><a class="email" href="mailto:gyuyoung.kim@webkit.org" title="Gyuyoung Kim <gyuyoung.kim@webkit.org>"> <span class="fn">Gyuyoung Kim</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=249460&action=diff" name="attach_249460" title="Patch">attachment 249460</a> <a href="attachment.cgi?id=249460&action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=249460&action=review">https://bugs.webkit.org/attachment.cgi?id=249460&action=review</a>

<span class="quote">> Source/WebCore/loader/WorkerThreadableLoader.cpp:169
>          delete responseData;</span >

I wonder if we should delete responseData. Because response.copyData() releases own pointer in 163 line. Then *responseData* looks manage the memory.

<span class="quote">> Source/WebCore/platform/network/cf/ResourceResponse.h:105
> +    void doPlatformAdopt(std::unique_ptr<CrossThreadResourceResponseData>) { }</span >

One question. Can't we move doPlatformCopyData() and doPlatformAdopt() declarations to ResourceResponseBase.h ?</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>