<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body><span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span> changed
              <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Update empty image canvas tests and fix a related bug"
   href="https://bugs.webkit.org/show_bug.cgi?id=142694">bug 142694</a>
        <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Attachment #249233 Flags</td>
           <td>review?
           </td>
           <td>review+, commit-queue-
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Update empty image canvas tests and fix a related bug"
   href="https://bugs.webkit.org/show_bug.cgi?id=142694#c17">Comment # 17</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Update empty image canvas tests and fix a related bug"
   href="https://bugs.webkit.org/show_bug.cgi?id=142694">bug 142694</a>
              from <span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=249233&action=diff" name="attach_249233" title="Patch">attachment 249233</a> <a href="attachment.cgi?id=249233&action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=249233&action=review">https://bugs.webkit.org/attachment.cgi?id=249233&action=review</a>

r=me with comments.

<span class="quote">> Source/WebCore/ChangeLog:28
> +        (WebCore::ImageLoader::updateFromElement): Fixed casting from CachedResourceHandle<CachedImage> to bool.</span >

Why? CachedResourceHandle has an operator for converting to bool already.

<span class="quote">> Source/WebCore/ChangeLog:48
> +        (WebCore::ImageLoader::clearImage):</span >

Unrelated change.

<span class="quote">> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:1756
> +    if (!image->complete() || !cachedImage)</span >

nit: I would find it more logical to reverse the checks to first check that the load has started THEN check that the load is not complete. Please also update the comment above accordingly.

<span class="quote">> Source/WebCore/loader/ImageLoader.cpp:238
> +        m_hasPendingLoadEvent = !!newImage;</span >

Unrelated change?</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>