<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body><span class="vcard"><a class="email" href="mailto:gyuyoung.kim@webkit.org" title="Gyuyoung Kim <gyuyoung.kim@webkit.org>"> <span class="fn">Gyuyoung Kim</span></a>
</span> changed
              <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Use std::unique_ptr instead of PassOwnPtr|OwnPtr for ScrollAnimator"
   href="https://bugs.webkit.org/show_bug.cgi?id=142143">bug 142143</a>
        <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Attachment #247625 Flags</td>
           <td>
                
           </td>
           <td>commit-queue+
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Use std::unique_ptr instead of PassOwnPtr|OwnPtr for ScrollAnimator"
   href="https://bugs.webkit.org/show_bug.cgi?id=142143#c4">Comment # 4</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Use std::unique_ptr instead of PassOwnPtr|OwnPtr for ScrollAnimator"
   href="https://bugs.webkit.org/show_bug.cgi?id=142143">bug 142143</a>
              from <span class="vcard"><a class="email" href="mailto:gyuyoung.kim@webkit.org" title="Gyuyoung Kim <gyuyoung.kim@webkit.org>"> <span class="fn">Gyuyoung Kim</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=247625&action=diff" name="attach_247625" title="Patch">attachment 247625</a> <a href="attachment.cgi?id=247625&action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=247625&action=review">https://bugs.webkit.org/attachment.cgi?id=247625&action=review</a>

cq=me.

<span class="quote">>> Source/WebCore/platform/ScrollAnimator.h:62
>> +    explicit ScrollAnimator(ScrollableArea&);

> It’s not so great that now a client can now accidentally create a ScrollAnimator directly with make_unique, when it should be calling ScrollAnimator::create.</span >

I also think like that. However, now we don't have best solution yet. In this case, lambdas looks not great benefit. When we have better solution, let's fix it again.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>