<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body><span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span> changed
              <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [WinCairo] Accelerated compositing should be disabled when graphics card does not support it."
   href="https://bugs.webkit.org/show_bug.cgi?id=140667">bug 140667</a>
        <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Attachment #244974 Flags</td>
           <td>review?
           </td>
           <td>review-
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [WinCairo] Accelerated compositing should be disabled when graphics card does not support it."
   href="https://bugs.webkit.org/show_bug.cgi?id=140667#c4">Comment # 4</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [WinCairo] Accelerated compositing should be disabled when graphics card does not support it."
   href="https://bugs.webkit.org/show_bug.cgi?id=140667">bug 140667</a>
              from <span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=244974&action=diff" name="attach_244974" title="Patch">attachment 244974</a> <a href="attachment.cgi?id=244974&action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=244974&action=review">https://bugs.webkit.org/attachment.cgi?id=244974&action=review</a>

I could see this making things a little harder to debug.  If we run into a problem in the future, we would also have to ask ourselves if it is a problem with the accelerated path or not.  Doesn't DirectX have a non-graphics-card implementation that ideally behaves the same, but slower?  Couldn't we use this through ANGLE instead of OpenGL?  If that's infeasible, then this is definitely the way to go.

<span class="quote">> Source/WebKit/win/WebCoreSupport/AcceleratedCompositingContext.cpp:248
> +bool AcceleratedCompositingContext::acceleratedCompositingAvailable()</span >

This and the declaration should probably also be inside #if USE(TEXTURE_MAPPER_GL)

<span class="quote">> Source/WebKit/win/WebCoreSupport/AcceleratedCompositingContext.cpp:263
> +        DestroyWindow(testWindow);</span >

::DestroyWindow here and elsewhere</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>