[Webkit-unassigned] [Bug 288693] New: GridPosition::gMaxPositionForTesting is not reset between tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=288693

            Bug ID: 288693
           Summary: GridPosition::gMaxPositionForTesting is not reset
                    between tests
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: fred.wang at free.fr
                CC: ap at webkit.org, rego at igalia.com, svillar at igalia.com

This issue was found recently in bug 288378 but was introduced a while ago in bug 170120 (https://commits.webkit.org/187201@main).

If your remove setGridMaxTracksLimit from skippedInternalFunctions and try

Tools/Scripts/run-webkit-tests --release --dump-render-tree --child-processes=1 LayoutTests/fast/harness/internals-object-property-access-on-window-without-frame-crash.html LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/anonymous-grid-item-001.html

then the grid test fails because GridPosition::gMaxPositionForTesting is not reset. The failure only seems to happen with DumpRenderTree.

Fortunately, this only seems to be used in one place

https://searchfox.org/wubkat/search?q=setGridMaxTracksLimit&path=&case=false&regexp=false

and the value used is still large, so probably it does not affect subsequent grid tests.

(internals-object-property-access-on-window-without-frame-crash.html was setting it to 1).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20250227/19d22825/attachment.htm>