[Webkit-unassigned] [Bug 287728] REGRESSION(285337 at main) [GTK] EWS layout test bots getting out of space due to sequence of assertions in IPC usage of g_socket_get_fd

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=287728

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cgarcia at igalia.com
            Summary|REGRESSION(290386 at main)     |REGRESSION(285337 at main)
                   |[GTK] EWS layout test bots  |[GTK] EWS layout test bots
                   |getting out of space due to |getting out of space due to
                   |sequence of assertions in   |sequence of assertions in
                   |IPC usage of                |IPC usage of
                   |g_socket_get_fd             |g_socket_get_fd

--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
I think this actually regressed in 285337 at main, where socketDescriptor() was introduced. Before, if readyReadHandler is called after the connection was closed, the read operation failed because the fd was -1, but now the socket is used and it's already nullptr. I think the safest approach would be to close the socket instead of setting it to nullptr and relay on the destructor to close it. That way the socket won't be nullptr, but -1 will be returned from g_socket_get_fd() when called after closed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20250219/acbf0f7a/attachment-0001.htm>