[Webkit-unassigned] [Bug 287405] New: REGRESSION(290096 at main) [GTK] GTK3 build failure due to missing includes for ImportNodeOptions and CustomElementRegistry

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=287405

            Bug ID: 287405
           Summary: REGRESSION(290096 at main) [GTK] GTK3 build failure due
                    to missing includes for ImportNodeOptions and
                    CustomElementRegistry
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKitGTK
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: lmoura at igalia.com
                CC: bugs-noreply at webkitgtk.org

/app/webkit/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentGtk.cpp:992:35:   required from here
/usr/include/c++/13.2.0/variant:759:44: error: ‘std::__detail::__variant::_Arr<_Ti>::_M_x’ has incomplete type
  759 |   template<typename _Ti> struct _Arr { _Ti _M_x[1]; };
      |                                            ^~~~
/app/webkit/WebKitBuild/GTK/Release/WebCore/PrivateHeaders/WebCore/Document.h:288:8: note: forward declaration of ‘struct WebCore::ImportNodeOptions’
  288 | struct ImportNodeOptions;
      |        ^~~~~~~~~~~~~~~~~
In file included from /app/webkit/WebKitBuild/GTK/Release/DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-18.cpp:2:
/app/webkit/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentGtk.cpp: In function ‘WebKitDOMNode* webkit_dom_document_import_node(WebKitDOMDocument*, WebKitDOMNode*, gboolean, GError**)’:
/app/webkit/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentGtk.cpp:992:60: error: cannot convert ‘gboolean’ {aka ‘int’} to ‘std::optional<std::variant<bool, WebCore::ImportNodeOptions> >&&’
  992 |     auto result = item->importNode(*convertedImportedNode, deep);
      |                                                            ^~~~
      |                                                            |
      |                                                            gboolean {aka int}
/app/webkit/WebKitBuild/GTK/Release/WebCore/PrivateHeaders/WebCore/Document.h:517:74: note:   initializing argument 2 of ‘WebCore::ExceptionOr<WTF::Ref<WebCore::Node> > WebCore::Document::importNode(WebCore::Node&, std::optional<std::variant<bool, WebCore::ImportNodeOptions> >&&)’
  517 |     WEBCORE_EXPORT ExceptionOr<Ref<Node>> importNode(Node& nodeToImport, std::optional<std::variant<bool, ImportNodeOptions>>&&);
      |                                                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


There's also another failure related to CustomElementRegistry not being defined after fixing this one.

Patch incoming.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20250210/344323c5/attachment-0001.htm>