[Webkit-unassigned] [Bug 278858] [GTK] [2.45.91] Fails to build in armhf: expected identifier before numeric constant

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=278858

Diego Pino <dpino at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dpino at igalia.com

--- Comment #4 from Diego Pino <dpino at igalia.com> ---
This a common error that happens when a header defining 'Success' collides with 'Xlib.h', which includes 'X11/X.h' which defines Success.

One way of solving is undefining 'Success' before including 'Xlib.h':

```
#ifdef Success
#undef Success
#endif
```

Another way of solving it is by adding the .c source file that triggers the inclusion of headers until the collide happens as no-unify. In this case, the file would be 'UIProcess/gtk/PointerLockManagerX11.cpp', but that file is already marked as no-unify: https://github.com/webkit/webkit/blob/main/Source/WebKit/SourcesGTK.txt#L283, so this solution won't work in your case.

It seems that right now there's no code in WebKit codebase that uses the former solution (undefining Success). So, if rearranging the order of the header fixes the issue I would go for that solution. Perhaps adding a comment explaining why 'Xlib.h' has to go after 'TZoneMallocInlines.h'.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240930/d92355a3/attachment.htm>