[Webkit-unassigned] [Bug 279660] New: REGRESSION(283334 at main): [GLIB] Script for updating third-party libs does not work anymore for flatpak

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=279660

            Bug ID: 279660
           Summary: REGRESSION(283334 at main): [GLIB] Script for updating
                    third-party libs does not work anymore for flatpak
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: clopez at igalia.com

Since 283334 at main the scripts update-webkitgtk-libs and update-webkitwpe-libs does not work anymore.

This is because the call to the script update-webkit-flatpak is now inside now a condition shouldUseFlatpak() that is always false at the invocation of that script due to this two reasons:

1. The subroutine shouldUseFlatpak() returns false if the ports is not specified, and this two scripts are usually called without passed the flag --gtk or --wpe
2. Even if you call the script passing the port as in "update-webkitgtk-libs --gtk" shouldUseFlatpak() will only return true if the flatpak is already installed, but it will not return true on the first run (no WebKitBuild dir) and we want to default to using flatpak unless the environment tells us to do something different.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240913/aa2b2464/attachment.htm>