[Webkit-unassigned] [Bug 279498] REGRESSION (282580 at main): 4.5MB binary size increase

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 12 08:00:55 PDT 2024


https://bugs.webkit.org/show_bug.cgi?id=279498

--- Comment #8 from Sam Weinig <sam at webkit.org> ---
(In reply to Gerald Squelart from comment #7)
> (Passer-by thought, please ignore if N/A)
> 
> Is the size regression mainly due to std::visit?
> If yes, would it be possible to only change WTF::switchOn (which is used 6-7
> times more often than naked std::visit) to accomplish most of the gains of
> mpark's re-implementation?

Yeah, that was what I meant to imply with "a more surgical fix". I was hoping I could just call mpark::visit(), and pass it a std::variant, but that doesn't work, so will need to lift the implementation up and refactor it so it can work with std::variant, which is doable, but a bit tricky.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240912/89ad42e6/attachment.htm>


More information about the webkit-unassigned mailing list