[Webkit-unassigned] [Bug 279216] New: REGRESSION(282648 at main): Speedometer 3.0 test TodoMVC-JavaScript-ES6-Webpack-Complex-DOM was regressed

Thu Sep 5 12:37:42 PDT 2024

https://bugs.webkit.org/show_bug.cgi?id=279216

            Bug ID: 279216
           Summary: REGRESSION(282648 at main): Speedometer 3.0 test
                    TodoMVC-JavaScript-ES6-Webpack-Complex-DOM was
                    regressed
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: DOM
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: sabouhallawa at apple.com

Updating the EffectiveTextDirection needs to be optimized when inserting an Element into ancestor.

What should happen regarding the text directionality if the <body> element in a large web page has this markup <body dir="ltr">?

Currently and because of this statement in Element::insertedIntoAncestor(), we end up calling updateEffectiveTextDirection() for every Element when it is parsed and inserted in its ancestor tree.

    if (UNLIKELY(selfOrPrecedingNodesAffectDirAuto() || (parent && parent->usesEffectiveTextDirection())))
        updateEffectiveTextDirection();

In this scenario we do not really need to call updateEffectiveTextDirection() unless one of the descendant has the dir attribute set.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240905/a5402fb0/attachment.htm>