[Webkit-unassigned] [Bug 279125] New: Simplify `isSVGRenderer()` in `RenderObject.h`

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 4 05:12:40 PDT 2024


https://bugs.webkit.org/show_bug.cgi?id=279125

            Bug ID: 279125
           Summary: Simplify `isSVGRenderer()` in `RenderObject.h`
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: bfulgham at webkit.org, simon.fraser at apple.com,
                    zalan at apple.com

Hi Team,

Just noticed following in RenderObject.h:

WebKit Source: https://searchfox.org/wubkat/rev/b36cbce69fddb7da33823f316bd8ead5bebee970/Source/WebCore/rendering/RenderObject.h#602

Current:

bool isSVGRenderer() const { return isRenderOrLegacyRenderSVGRoot() || isLegacyRenderSVGModelObject() || isRenderSVGModelObject() || isRenderSVGBlock() || isRenderSVGInline(); }

Where:

isLegacyRenderSVGModelObject() || isRenderSVGModelObject() -> can be replaced with (isRenderOrLegacyRenderSVGModelObject())

Which in turn will make `isSVGRenderer` as:

bool isSVGRenderer() const { return isRenderOrLegacyRenderSVGRoot() || isRenderOrLegacyRenderSVGModelObject() || isRenderSVGBlock() || isRenderSVGInline(); }

___

Just raising so we can do this clean-up.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240904/267c337b/attachment.htm>


More information about the webkit-unassigned mailing list