[Webkit-unassigned] [Bug 279111] New: [WPE][GTK] API tests runner reports Crash when it shouldn't

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=279111

            Bug ID: 279111
           Summary: [WPE][GTK] API tests runner reports Crash when it
                    shouldn't
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: dpino at igalia.com

After the switch to GTK4, there's a test: TestContextMenu that is returning a Crash when run.

"Crashed": [
  {
    "name": "/WebKitGTK/TestContextMenu:(problem in test executable)",
  }
],

The Crash is reported for the binary itself and not a particular subtest, which is what would have been expected.

Reviewing the code, the problem is that right now TestContextMenu doesn't emit any subtest for GTK4. The following snippet of code in `Tools/glib/api_test_runner.py` reports that as a crash, when it shouldn't:

```
results = self._run_test(test, subtests, skipped_subtests)
if len(results) == 0:
    # No subtests were emitted, either the test binary didn't exist, or we don't know how to run it, or it crashed.
    sys.stderr.write("ERROR: %s failed to run, as it didn't emit any subtests.\n" % test)
    crashed_tests[test] = ["(problem in test executable)"]
```

The condition should `len(subtests) > 0 and len(results) == 0`.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240904/3e6b1b6b/attachment.htm>