[Webkit-unassigned] [Bug 282288] REGRESSION(282580 at main): Static assertions failing in CalculationTree.h and CSSCalcTree.h on i686

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 29 15:13:14 PDT 2024


https://bugs.webkit.org/show_bug.cgi?id=282288

Michael Catanzaro <mcatanzaro at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at redhat.com

--- Comment #1 from Michael Catanzaro <mcatanzaro at redhat.com> ---
Hey Sam, I'm not sure what to do about this. Normally when we have sizeof-related static assertion failures, the assertion is "foo should stay small" and the solution is to assert that the size of a struct or class's member variables adds up to the size of the pointers or primitive types that its members contain. But in this case, we're asserting that the size is exactly one particular value. I don't see any reason the code would require the variants to be these particular sizes, so we'll need you to explain please.

Maybe you just want the variants to be generally relatively small, and these should be changed to use <= rather than ==?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20241029/c18f6224/attachment.htm>


More information about the webkit-unassigned mailing list