[Webkit-unassigned] [Bug 282239] [WPE][GTK] Replace various WTF_ALLOW_UNSAFE_BUFFER_USAGE_BEGIN with unsafeForgeSpan

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 29 10:33:50 PDT 2024


https://bugs.webkit.org/show_bug.cgi?id=282239

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com

--- Comment #1 from Adrian Perez <aperez at igalia.com> ---
(In reply to Michael Catanzaro from comment #0)
> In 285787 at main I used WTF_ALLOW_UNSAFE_BUFFER_USAGE_BEGIN to fix the build
> with Clang 19, but most of these are not needed. I should have used
> unsafeForgeSpan instead.

Careful, instead of using unsafeForgeSpan() everywhere, we would rather
use helper functions that ensure that the right thing gets done, as in
https://github.com/WebKit/WebKit/pull/35830

I would rather go through each WTF_ALLOW_UNSAFE_BUFFER_USAGE_BEGIN
suppression one by one deciding what to do; blindly converting to use
std::span does not ensure they are safe to use.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20241029/7add66a4/attachment.htm>


More information about the webkit-unassigned mailing list