[Webkit-unassigned] [Bug 282067] New: [JSC] Remove outdated FIXME in JSDOMConvertDate.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=282067

            Bug ID: 282067
           Summary: [JSC] Remove outdated FIXME in JSDOMConvertDate.h
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ian.grunert at gmail.com

In JSDOMConvertDate there's a fixme:

// FIXME: This should be taking a JSDOMGlobalObject and passing it to jsDate.

which is confusing because it's taking a JSC::JSGlobalObject& lexicalGlobalObject, and it's unclear why a JSDOMGlobalObject would be better.

The reason for the FIXME appears to be that this function used to accept a JSC::ExecState& state - but in bug 202392 we switched away from that. So it looks like we just forgot to remove the FIXME when we made the relevant change.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20241024/b2d9fe28/attachment.htm>