[Webkit-unassigned] [Bug 282039] New: ODR violation due to redefinition of maxTitleLength contant

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=282039

            Bug ID: 282039
           Summary: ODR violation due to redefinition of maxTitleLength
                    contant
           Product: WebKit
           Version: WebKit Local Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Process Model
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: bartosz.moczulski at youview.com
                CC: nham at apple.com

Created attachment 473032

  --> https://bugs.webkit.org/attachment.cgi?id=473032&action=review

Fix proposal

With UnifiedSources `--max-bundle-size` set to 16 it is possible for WebLocalFrameLoaderClient.cpp and WebChromeClient.cpp to end up in a single compilation unit. The fact that they both contain a static `maxTitleLength` constant in `WebKit` namespace results in an ODR violation during an attempt to compile them both together.

Fix proposal (attached): move maxTitleLength into functions where they are actually needed, like in SessionStateConversion.cpp.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20241024/36338d2a/attachment.htm>