[Webkit-unassigned] [Bug 283435] New: Web Inspector: Remove the unused WebInspector::canAttachWindow and places storing its return value

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=283435

            Bug ID: 283435
           Summary: Web Inspector: Remove the unused
                    WebInspector::canAttachWindow and places storing its
                    return value
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: qianlangchen at apple.com
                CC: inspector-bugzilla-changes at group.apple.com

The patch https://github.com/apple/WebKit/pull/2291 (to bug https://webkit.org/b/283092 or rdar://98891055) made the WebInspector::canAttachWindow function in the web process not useful anymore. The function's return value used to be sent over to the UI process via the WebInspectorUIProxy::OpenLocalFrontend message, where the UI process then decides, using that sent value alongside running platformCanAttach, whether the new inspector window can be attached. However, on macOS, platformCanAttach already computes the same thing as WebInspector::canAttachWindow, and no other implementations of WebInspectorUIProxy make use of the web process's value. Therefore WebInspector::canAttachWindow is now obsolete.

Deprecating WebInspector::canAttachWindow could also mean that the m_attached and m_previouslyAttached member variables for both WebInspector and WebInspectorUIProxy all become useless too, so would the webProcessCanAttach parameter of WebInspectorUIProxy::platformCanAttach also become unused. If we can verify that's the case then we should probably remove those too to keep our code clean.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20241120/5480762e/attachment.htm>