[Webkit-unassigned] [Bug 283351] New: [Skia] Ensure the correct .addrXYZ() method is used for pixel data access

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 19 01:52:33 PST 2024


https://bugs.webkit.org/show_bug.cgi?id=283351

            Bug ID: 283351
           Summary: [Skia] Ensure the correct .addrXYZ() method is used
                    for pixel data access
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aperez at igalia.com
                CC: bfulgham at webkit.org, simon.fraser at apple.com,
                    zalan at apple.com

The SkPixmap::[writable_]addr{8,16,32,64,F16}() functions include assertions
(which may be enabled via the SKIA_DEBUG=ON CMake option) that check whether
the pixel format bit width matches the intended usage of the method. For
example ::addr32() works with ARGB8888/BGRA8888/etc. but will crash on the
assertion with an RGB565 image.

We should audit the call sites for these functions and make sure the correct
ones are used. When handling can be generic regardless of the pixel format
bit widthl, usage must be replaced with the unsuffixed ::[writable_]addr()
functions instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20241119/0b49dd12/attachment.htm>


More information about the webkit-unassigned mailing list