[Webkit-unassigned] [Bug 283253] New: Refactor webkitscmpy.program.canonicalize.message to be more testable

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 16 20:16:41 PST 2024


https://bugs.webkit.org/show_bug.cgi?id=283253

            Bug ID: 283253
           Summary: Refactor webkitscmpy.program.canonicalize.message to
                    be more testable
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: gsnedders at apple.com

Currently it's a singular, big main function.

We should split it up to call into a smaller `rewrite_message` which can be tested in isolation.

https://github.com/WebKit/WebKit/pull/36498 added a lot of tests here, but it does so in the same way as the existing tests: with a huge amount of setup, relying on our git mock, rather than testing the unit we actually care about here: how we rewrite the message.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20241117/8f40880c/attachment.htm>


More information about the webkit-unassigned mailing list