[Webkit-unassigned] [Bug 274969] New: Two files include <Timer.h> instead of "Timer.h"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=274969

            Bug ID: 274969
           Summary: Two files include <Timer.h> instead of "Timer.h"
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Mac (Apple Silicon)
                OS: macOS 14
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: tolmasky at gmail.com

Both "WebCore/platform/mediastream/RealtimeOutgoingVideoSource.h" and "WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h" use "#include <Timer.h>" instead of "#include "Timer.h"". They seem to be the only two instances of using <> to do a peer search. As far as I can tell there is no specific reason for this, that is to say, it is not a workaround for finding the wrong Timer.h or something. I have changed them to "Timer.h" and it compiled fine. The current use of "<Timer.h>" is causing issues when I am trying to include these files somewhere else. You get the following error:

error: 'Timer.h' file not found with <angled> include; use "quotes" instead
   35 | #include <Timer.h>
      |          ^~~~~~~~~
      |          "Timer.h"

If there is no reason for using "Timer.h", can I submit a PR changing to use "Timer.h"?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240531/718d4209/attachment.htm>