[Webkit-unassigned] [Bug 274914] New: Web Inspector: DebuggerManager. _associateBreakpointsWithSourceCode should only allow updates from the main frame

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 30 11:53:10 PDT 2024


https://bugs.webkit.org/show_bug.cgi?id=274914

            Bug ID: 274914
           Summary: Web Inspector: DebuggerManager.
                    _associateBreakpointsWithSourceCode should only allow
                    updates from the main frame
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: qianlangchen at apple.com
                CC: inspector-bugzilla-changes at group.apple.com

The patch https://github.com/WebKit/WebKit/pull/27000 makes DebuggerManager._associateBreakpointsWithSourceCode always able to update a breakpoint's linked-to source code in order to prevent those source code objects becoming stale when e.g. the page reloads. However, as pointed out [in a code-review comment](https://github.com/WebKit/WebKit/pull/27000/files#r1609384544), this fix might cause issues when there are resources with the same URL/contentIdentifier coming from a sub-frame. Despite that perhaps being quite an unlikely scenario, we should consider improving that resource-updating logic and maybe apply the suggested fix in that comment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20240530/aed0399e/attachment.htm>


More information about the webkit-unassigned mailing list